Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: UX improvements regarding agent activity #349

Merged
merged 11 commits into from
Sep 13, 2024
Merged

feat!: UX improvements regarding agent activity #349

merged 11 commits into from
Sep 13, 2024

Conversation

mohandast52
Copy link
Collaborator

@mohandast52 mohandast52 commented Sep 12, 2024 •
edited
Loading

Proposed changes

Please test all the different stages, including Start, Stop, agent running/pausing, etc.

  • The last transaction made successfully
Scr2
  • Tooltip info
Screen22M
  • NOTE: 👇 This situation will occur if there's an error in fetching the transaction or if the blockNumber is too far behind, reaching a maximum of (latest - (10 * 9000)). In simpler terms, we can only go back 10 rounds, with each round covering 9000 blocks.
Sc2
  • Loading state
Scre1M

Text changes

Sc1M S222

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mohandast52 mohandast52 added the enhancement New feature or request label Sep 12, 2024
@mohandast52 mohandast52 self-assigned this Sep 12, 2024
@mohandast52 mohandast52 changed the title UX improvements regarding agent activity !feat: UX improvements regarding agent activity Sep 12, 2024
@mohandast52 mohandast52 changed the title !feat: UX improvements regarding agent activity feat!: UX improvements regarding agent activity Sep 13, 2024
@mohandast52 mohandast52 marked this pull request as ready for review September 13, 2024 10:09
Tanya-atatakai
Tanya-atatakai approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@Tanya-atatakai Tanya-atatakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really nice!

frontend/components/MainPage/header/LastTransaction.tsx Outdated Show resolved Hide resolved
frontend/components/MainPage/header/LastTransaction.tsx Outdated Show resolved Hide resolved
frontend/service/Ethers.ts Show resolved Hide resolved
truemiller
truemiller approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@truemiller truemiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two tiny changes, but not blocking

@mohandast52 mohandast52 merged commit 412449a into staging Sep 13, 2024
4 checks passed
@mohandast52 mohandast52 deleted the mohan/agent-activity branch September 13, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tanya-atatakai Tanya-atatakai Tanya-atatakai approved these changes

@truemiller truemiller truemiller approved these changes

@oaksprout oaksprout Awaiting requested review from oaksprout

Assignees

@mohandast52 mohandast52

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohandast52 @Tanya-atatakai @truemiller