Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simpler frontend #43

Merged
merged 17 commits into from
Mar 28, 2024
Merged

Simpler frontend #43

merged 17 commits into from
Mar 28, 2024

Conversation

truemiller
Copy link
Collaborator

@truemiller truemiller commented Mar 26, 2024 •
edited
Loading

  • Removed unused components, pages, hooks .etc
  • Base UI refactor to achieve Figma designs see below; will polish later, smaller PRs.
  • Basic onboarding flow, no styling, no need for screenshots
  • Service updates for new spawn endpoints, lacking comments, with add in later PRs
  • New ESLint rules to sort and aggregate imports nicely 🥳

Figma
image

Main UI Will polish in later PRs
image

image

image

@truemiller truemiller requested a review from mohandast52 March 26, 2024 15:29
@truemiller truemiller changed the base branch from refactor/api to main March 27, 2024 11:29
mohandast52
mohandast52 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@mohandast52 mohandast52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

electron/main.js Outdated Show resolved Hide resolved
frontend/.eslintrc.json Show resolved Hide resolved
frontend/pages/index.tsx Outdated Show resolved Hide resolved
frontend/pages/index.tsx
<span style={{ fontSize: 64, fontWeight: 900 }}>2,101</span>
</Typography>
<Typography
style={{ display: 'flex', flexWrap: 'nowrap', fontSize: 18 }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have Flex in antd

frontend/components/Setup.tsx Outdated Show resolved Hide resolved
@truemiller truemiller merged commit 3d76fc9 into main Mar 28, 2024
3 checks passed
@truemiller truemiller deleted the simpler-frontend branch April 5, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohandast52 mohandast52 mohandast52 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@truemiller @mohandast52