fix: flickering debug for agents.fun #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohandast52
commented
Dec 18, 2024
| Math.ceil(nowInSeconds - tsCheckpoint), | ||
| ), | ||
| ]); | ||
| const isServiceStaked = serviceInfo[2].length > 0; |
There was a problem hiding this comment.
we were passing an empty array and the contract call was failing.
mohandast52
commented
Dec 18, 2024
| @@ -48,7 +48,7 @@ export abstract class MemeooorBaseService extends StakedAgentService { | |||
| stakingTokenProxyContract.minStakingDeposit(), | |||
| stakingTokenProxyContract.tsCheckpoint(), | |||
| activityChecker.livenessRatio(), | |||
| activityChecker.getMultisigNonces(), | |||
| activityChecker.getMultisigNonces(agentMultisigAddress), | |||
There was a problem hiding this comment.
I checked the ABI, and it seems we’re supposed to pass the argument, which is the error I shared in the group. (Also, we were not catching hence moved inside "Try" block)
Tanya-atatakai
approved these changes
Dec 18, 2024
truemiller
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply