Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Support ERC20 in funding job #630

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Feat: Support ERC20 in funding job #630

merged 2 commits into from
Dec 24, 2024

Conversation

OjusWiZard
Copy link
Member

@OjusWiZard OjusWiZard commented Dec 24, 2024 •
edited
Loading

Proposed changes

  • update the service templates to configure fund_requirements for ERC20 tokens
  • support funding ERC20 tokens in the funding logic

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@OjusWiZard
style: fix CI lint checks
54a1e73 
Signed-off-by: OjusWiZard <[email protected]>
0xArdi
0xArdi approved these changes Dec 24, 2024
View reviewed changes
tox.ini
@@ -230,6 +230,9 @@ ignore_missing_imports = True
[mypy-deepdiff.*]
ignore_missing_imports = True

[mypy-twikit.*]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where's this even used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's used for validating the twitter cookies

@OjusWiZard OjusWiZard merged commit 65ceeb3 into feature/modius Dec 24, 2024
5 checks passed
@OjusWiZard OjusWiZard deleted the feat/erc20-funding branch December 24, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xArdi 0xArdi 0xArdi approved these changes

@Tanya-atatakai Tanya-atatakai Awaiting requested review from Tanya-atatakai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OjusWiZard @0xArdi