You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Some base rounds require a number of base attributes to be defined by the superclasses. For example, none_type on CollectSameUntilThresholdRound.
If the superclass fails to initialize these attributes, the business logic will proceed without a warning. However, if during the execution variable is required to launch an event, it will crash the application when accessing that attribute.
Describe the solution you'd like
In summary, the application should throw a warning or exception when these required attributes are not initialized. This applies to several other base round classes.
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered:
jmoreira-valory
changed the title
Enforce base rounds to always define required attributes
Enforce superclases of base rounds to always define required attributes
Jul 10, 2024
jmoreira-valory
changed the title
Enforce superclases of base rounds to always define required attributes
Enforce superclasses of base rounds to always define required attributes
Jul 10, 2024
The solution in #2276 does not align with the intended one for this issue.
The agent crashes after it has started running, and only if the problematic round is entered.
Instead, we wanted to achieve a solution in which the check happens before the FSM cycle starts.
Is your feature request related to a problem? Please describe.
Some base rounds require a number of base attributes to be defined by the superclasses. For example, none_type on
CollectSameUntilThresholdRound
.If the superclass fails to initialize these attributes, the business logic will proceed without a warning. However, if during the execution variable is required to launch an event, it will crash the application when accessing that attribute.
Describe the solution you'd like
In summary, the application should throw a warning or exception when these required attributes are not initialized. This applies to several other base round classes.
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: