Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Strict checks in rounds' for properties #2276

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

OjusWiZard
Copy link
Member

Proposed changes

Strictly check if the required properties are defined in derived classes from AbstractRound

Fixes

#2246

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run services that could be impacted and they do not present failures derived from my changes
  • Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
  • Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@OjusWiZard OjusWiZard force-pushed the feat/abstract-rounds branch 3 times, most recently from 3c994c6 to dccd962 Compare November 1, 2024 22:22
jmoreira-valory
jmoreira-valory previously approved these changes Nov 4, 2024
@OjusWiZard OjusWiZard force-pushed the feat/abstract-rounds branch 2 times, most recently from da4b2c3 to 73425f0 Compare November 14, 2024 18:02
@OjusWiZard OjusWiZard merged commit 27be61e into main Nov 15, 2024
23 checks passed
@OjusWiZard OjusWiZard deleted the feat/abstract-rounds branch November 15, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants