Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies clean up #2062

Merged
merged 9 commits into from
Sep 22, 2023
Merged

Dependencies clean up #2062

merged 9 commits into from
Sep 22, 2023

Conversation

angrybayblade
Copy link
Contributor

@angrybayblade angrybayblade commented Sep 22, 2023

Proposed changes

This PR

  • Removed numpy and pandas as dependencies
  • Updates the benchmark aggregator to remove the usage of pandas
  • Pins pytest and coverage as CLI deps

Fixes

Closes #1426.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run services that could be impacted and they do not present failures derived from my changes
  • Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
  • Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

@angrybayblade angrybayblade changed the title Remove unwanted deps Dependencies clean up Sep 22, 2023
Copy link
Collaborator

@Adamantios Adamantios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming that the updated benchmark tools have been tested and work.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8378f56) 94.26% compared to head (41ed034) 94.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2062   +/-   ##
=======================================
  Coverage   94.26%   94.27%           
=======================================
  Files         263      263           
  Lines       15926    15955   +29     
=======================================
+ Hits        15013    15041   +28     
- Misses        913      914    +1     
Flag Coverage Δ
unittests 94.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
autonomy/analyse/benchmark/aggregate.py 100.00% <100.00%> (ø)
autonomy/analyse/benchmark/html.py 100.00% <100.00%> (ø)
autonomy/constants.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angrybayblade angrybayblade merged commit 83d641f into main Sep 22, 2023
22 of 26 checks passed
@DavidMinarsch DavidMinarsch deleted the chore/remove-unwanted-deps branch November 25, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove numpy and pandas dependencies
2 participants