Bump [email protected]
#2065
Merged
Bump [email protected]
#2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Include install and build scripts in the base image - Remove unwanted layers - Remove unwanted data files
Release `v0.13.0`
angrybayblade
commented
Sep 27, 2023
Comment on lines
-113
to
+114
| wget https://github.com/protocolbuffers/protobuf/releases/download/v3.19.4/protoc-3.19.4-linux-x86_64.zip | ||
| unzip protoc-3.19.4-linux-x86_64.zip -d protoc | ||
| wget https://github.com/protocolbuffers/protobuf/releases/download/v24.3/protoc-24.3-linux-x86_64.zip | ||
| unzip protoc-24.3-linux-x86_64.zip -d protoc |
There was a problem hiding this comment.
Bumped because of the protobuf bump
Comment on lines
+242
to
+254
| .PHONY: build-proto | ||
| build-proto: | ||
| @protoc -I $$INCLUDE \ | ||
| --proto_path=packages/valory/connections/abci/protos/ \ | ||
| --python_out=packages/valory/connections/abci/ \ | ||
| packages/valory/connections/abci/protos/gogoproto/gogo.proto \ | ||
| packages/valory/connections/abci/protos/tendermint/crypto/proof.proto \ | ||
| packages/valory/connections/abci/protos/tendermint/crypto/keys.proto \ | ||
| packages/valory/connections/abci/protos/tendermint/abci/types.proto \ | ||
| packages/valory/connections/abci/protos/tendermint/types/types.proto \ | ||
| packages/valory/connections/abci/protos/tendermint/types/validator.proto \ | ||
| packages/valory/connections/abci/protos/tendermint/types/params.proto \ | ||
| packages/valory/connections/abci/protos/tendermint/version/types.proto |
There was a problem hiding this comment.
To build the abci connection protos
Comment on lines
+119
to
+136
| def load_hwi_plugin() -> Type[LedgerApi]: # pragma: nocover | ||
| """Load HWI Plugin.""" | ||
| try: | ||
| from aea_ledger_ethereum_hwi.hwi import ( # pylint: disable=import-outside-toplevel | ||
| EthereumHWIApi, | ||
| ) | ||
|
|
||
| return EthereumHWIApi | ||
| except ImportError as e: | ||
| raise click.ClickException( | ||
| "Hardware wallet plugin not installed, " | ||
| "Run `pip3 install open-aea-ledger-ethereum-hwi` to install the plugin" | ||
| ) from e | ||
| except TypeError as e: | ||
| raise click.ClickException( | ||
| 'Protobuf compatibility error; Please export PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION="python" ' | ||
| "to use the hardware wallet without any issues" | ||
| ) from e |
There was a problem hiding this comment.
Lazy loading to avoid the protobuf incompatibility issue valory-xyz/open-aea#671
dvilelaf
reviewed
Sep 27, 2023
Comment on lines
+34
to
+38
| from packages.valory.connections.abci.tendermint.abci.types_pb2 import ( # type: ignore | ||
| LastCommitInfo as LastCommitInfoPb, | ||
| ) | ||
| from packages.valory.connections.abci.tendermint.abci.types_pb2 import Request | ||
| from packages.valory.connections.abci.tendermint.abci.types_pb2 import ( | ||
| from packages.valory.connections.abci.tendermint.abci.types_pb2 import Request # type: ignore | ||
| from packages.valory.connections.abci.tendermint.abci.types_pb2 import ( # type: ignore |
There was a problem hiding this comment.
What has changed that we need so many type ignores now?
There was a problem hiding this comment.
The new version of protobufs does not define these objects explicitly, rather they are built at the compile time so the *_pb.py files don't contain any explicitly defined objects so the type checks fail there
dvilelaf
previously approved these changes
Sep 27, 2023
Optimise images
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2065 +/- ##
==========================================
- Coverage 94.27% 94.23% -0.04%
==========================================
Files 263 263
Lines 15955 15956 +1
==========================================
- Hits 15041 15036 -5
- Misses 914 920 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
dvilelaf
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
protobuf<5.0.0,>=4.21.6andweb3<7,>=6.0.0v24.3Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
xin the box that appliesChecklist
Put an
xin the boxes that apply.mainbranch (left side). Also you should start your branch off ourmain.