Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning if the termination skill is missing as a dependency #2076

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

angrybayblade
Copy link
Contributor

@angrybayblade angrybayblade commented Oct 4, 2023

Proposed changes

This PR updates the service analyser to warn if the termination skill is not defined as a dependency in the agent and the ABCI skill

Fixes

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run services that could be impacted and they do not present failures derived from my changes
  • Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
  • Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d3b072e) 85.86% compared to head (e1d1546) 94.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2076      +/-   ##
==========================================
+ Coverage   85.86%   94.21%   +8.34%     
==========================================
  Files         263      263              
  Lines       15979    15987       +8     
==========================================
+ Hits        13721    15062    +1341     
+ Misses       2258      925    -1333     
Flag Coverage Δ
unittests 94.21% <87.50%> (+8.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
autonomy/analyse/service.py 98.09% <87.50%> (-0.34%) ⬇️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angrybayblade angrybayblade merged commit bba96bd into main Oct 5, 2023
24 checks passed
@Adamantios
Copy link
Collaborator

I guess we could do the same for slashing_abci in this PR.

@DavidMinarsch DavidMinarsch deleted the feat/termination-skill-missing branch November 25, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants