Use environment variable for passing the private key password #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y password and env var for kubernetes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2094 +/- ##
=======================================
Coverage 94.14% 94.14%
=======================================
Files 255 255
Lines 15789 15783 -6
=======================================
- Hits 14864 14859 -5
+ Misses 925 924 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
angrybayblade
commented
Oct 26, 2023
Comment on lines
+613
to
+614
| if self.deplopyment_type == DOCKER_COMPOSE_DEPLOYMENT: | ||
| agent_vars[ENV_VAR_AEA_PASSWORD] = "$OPEN_AUTONOMY_PRIVATE_KEY_PASSWORD" |
There was a problem hiding this comment.
This will store the value of AEA_PASSWORD as $OPEN_AUTONOMY_PRIVATE_KEY_PASSWORD in the docker-compose.yaml so the user can pass the password as OPEN_AUTONOMY_PRIVATE_KEY_PASSWORD when running the deployment
Comment on lines
+616
to
+618
| agent_vars[ENV_VAR_AEA_PASSWORD] = os.environ.get( | ||
| "OPEN_AUTONOMY_PRIVATE_KEY_PASSWORD", "" | ||
| ) |
There was a problem hiding this comment.
Unfortunately the kubernetes does not provide such functionalities so we'll have to store them the old way
Adamantios
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
--passwordflagOPEN_AUTONOMY_PRIVATE_KEY_PASSWORDas environment variable for passing private key passwordFixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
xin the box that appliesChecklist
Put an
xin the boxes that apply.mainbranch (left side). Also you should start your branch off ourmain.