Fix/mech integration #216
Merged
Fix/mech integration #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamantios
reviewed
Feb 1, 2024
Adamantios
reviewed
Feb 1, 2024
Comment on lines
+248
to
+257
| res = {} | ||
| for abi in partial_abis: | ||
| contract_instance = ledger_api.api.eth.contract(contract_address, abi=abi) | ||
| res = cls._process_event( | ||
| ledger_api, contract_instance, tx_hash, "Request", "requestId", "data" | ||
| ) | ||
| if "error" not in res: | ||
| return res | ||
|
|
||
| return res |
There was a problem hiding this comment.
A process_mech_event can be extracted here, accepting the type of the request as an argument, to avoid code dup.
Adamantios
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues discovered during integration with the mech running on nevermined:
Addition of Subscription approval
The mech needs to be approved to spend the trader's subscription
Support for multiple Request/Deliver event formats
The new mech has a different Request event signature