Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBD Fractal Components #505

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
8d35f6e
[#187227450] create new card block component
Apr 2, 2024
4ef3be3
[#187227450] remove static min-heights from card content
Apr 3, 2024
36fdef8
[#187227450] create new carousel block component
Apr 3, 2024
7c8aff8
[#187227450] new button variations and html button option added
Apr 3, 2024
12ed686
[#187227450] create new quicklinks block component
Apr 3, 2024
03b168f
[#187227450] create master brand nav block component
Apr 4, 2024
43d76c6
[#187227450] ensure elements exist before executing js code
Apr 4, 2024
90541bd
Merge branch 'main' into feature-187227450
Apr 9, 2024
842f0ed
[#187227450] rename label-tag variant
Apr 9, 2024
0a240a9
[#187227450] rework master brand nav block to correct component
Apr 9, 2024
4ba823e
[#187227450] rework navigation button variant to requested component
Apr 10, 2024
586bc4f
[#187227450] remove swiper library and implement simple custom carous…
Apr 10, 2024
6b2d3ec
[#187227450] fix remaining linting errors
Apr 10, 2024
5c8b4c1
[#187227450] various minor fixes and cleanup
Apr 16, 2024
57be583
add default focus styles (accessibility requirement)
methodog Apr 17, 2024
23e7ca1
carousel: fix keyboard & screenreader accessibility; add swipe gestur…
methodog Apr 17, 2024
c7b5498
supply proper full image srcset, needed for testing responsive img tag
methodog Apr 17, 2024
09a1858
[#187227450] remove quicklinks button variant
Apr 18, 2024
efc3e30
[#187227450] add quicklinks button styles to component and remove pre…
Apr 18, 2024
7736a69
[#187227450] update image src sizes to correctly correspond with brea…
Apr 18, 2024
ccc67b6
[#187227450] remove references to removed scripts
Apr 18, 2024
965a131
cleanup after moving these style into Quicklink component
methodog Apr 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[#187227450] remove static min-heights from card content
  • Loading branch information
Miles Lemon committed Apr 3, 2024
commit 4ef3be3172095672d8812c29089b243af736714c
7 changes: 0 additions & 7 deletions src/components/blocks/card/_card.scss
Original file line number Diff line number Diff line change
@@ -94,23 +94,16 @@
display: flex;
flex-direction: column;
border-bottom: 1px solid base.sitecolors-siteColor("vam-grey-7");
min-height: 140px;

@include mixins.breakpoints-bpMinSmall {
margin-left: 24px;
min-height: auto;
width: calc(50% - 24px);
}

@include mixins.breakpoints-bpMinMedium {
margin-left: 0;
min-height: 170px;
width: 100%;
}

@include mixins.breakpoints-bpMinMedium {
min-height: 150px;
}
}

&__title {