fix: fixed memleaks and predefinedfilterscombobox and abstractlogview #730
Conversation
| @@ -102,6 +102,11 @@ PredefinedFiltersComboBox::PredefinedFiltersComboBox( QWidget* parent ) | |||
| setSizeAdjustPolicy( QComboBox::AdjustToContents ); | |||
| } | |||
|
|
|||
| PredefinedFiltersComboBox::~PredefinedFiltersComboBox() | |||
| { | |||
| delete model_; | |||
There was a problem hiding this comment.
Setting this as a parent for the model object in PredefinedFiltersComboBox constructor is a more "Qt" way to manage this without creating explicit destructors.
There was a problem hiding this comment.
Setting this as a parent for the model object in PredefinedFiltersComboBox constructor is a more "Qt" way to manage this without creating explicit destructors.
leave this change?
| @@ -172,6 +177,7 @@ void PredefinedFiltersComboBox::setTitle( const QString& title ) | |||
| { | |||
| auto* titleItem = new QStandardItem( title ); | |||
| model_->insertRow( 0, titleItem ); | |||
| delete titleItem; | |||
There was a problem hiding this comment.
As far as I understand after insertRow call the ownership should be transferred to the model.
There was a problem hiding this comment.
As far as I understand after insertRow call the ownership should be transferred to the model.
leave this change?
| @@ -536,9 +536,11 @@ AbstractLogView::~AbstractLogView() | |||
| try { | |||
| if ( quickFind_ ) { | |||
| quickFind_->stopSearch(); | |||
| delete quickFind_; | |||
There was a problem hiding this comment.
Good find!
leave this change?
|
@variar, oh my goh! |
fixed direct memleaks