parser: Switch from ansi_term to colored crate
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change looks reasonable to me and with the example interfaction definition from varlink.org worked for me and had the correct colours (or at least the same compared to the main branch) |
|
Seems like I will have to increase the minimum version |
Pull Request Test Coverage Report for Build 8286841734Details
💛 - Coveralls |
Yeah, why not. Want me to provide a PR? |
Yes please and thank you! |
Done. |
`ansi_term` is no longer maintained and for the simple needs here, `colored` is much better suited anyway. Fixes varlink#99. Signed-off-by: Zeeshan Ali Khan <[email protected]>
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ansi_termis no longer maintained and for the simple needs here,coloredis much better suited anyway.Fixes #99.