Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admonition Changes #401

Merged
merged 3 commits into from
Dec 15, 2024
Merged

Admonition Changes #401

merged 3 commits into from
Dec 15, 2024

Conversation

alphadelta332
Copy link
Contributor

@alphadelta332 alphadelta332 commented Dec 13, 2024 •
edited
Loading

Changes

Fixes:

  • Fixed other custom admonitions that were showing without any formatting, such as information, caution, and important

Additions:

  • Created new "Phraseology" Admonition (Separate from examples)
firefox_vvDcemZuHi

@alphadelta332 alphadelta332 requested a review from a team December 13, 2024 07:02
mattkelly4
mattkelly4 requested changes Dec 13, 2024
View reviewed changes
docs/assist-us/best-practices.md Outdated Show resolved Hide resolved
docs/assist-us/best-practices.md Outdated Show resolved Hide resolved
@alphadelta332 alphadelta332 requested review from mattkelly4 and a team December 13, 2024 09:20
@mattkelly4 mattkelly4 added the notify Send notification to Discord on merge label Dec 15, 2024
@mattkelly4 mattkelly4 merged commit 1c4e38d into main Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerthetiletiler tylerthetiletiler tylerthetiletiler approved these changes

@mattkelly4 mattkelly4 mattkelly4 approved these changes

@LeGiraffe LeGiraffe Awaiting requested review from LeGiraffe

Assignees
No one assigned
Labels
notify Send notification to Discord on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alphadelta332 @mattkelly4 @tylerthetiletiler