SKA-504: throw for nonexistent files (#27)

vectorgrp · May 17, 2024 · 42a0090 · 42a0090
1 parent 98530b6
commit 42a0090
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/advalues/adapter/AdManager.cpp b/advalues/adapter/AdManager.cpp
@@ -3,6 +3,7 @@
 #include "AdManager.hpp"
 
 #include <algorithm>
+#include <filesystem>
 #include <sys/inotify.h>
 
 #include "../../util/Exceptions.hpp"
@@ -46,6 +47,11 @@ void AdManager::InitAdaptersFromConfigFile(const YAML::Node& configFile,
             std::unique_ptr<PubSubSpec> subDataSpec, pubDataSpec;
             std::string publisherName, subscriberName;
 
+            if (!std::filesystem::exists(fileValuesYaml.path + fileValuesYaml.fileName))
+            {
+                throw std::runtime_error("file " + fileValuesYaml.path + fileValuesYaml.fileName + " does not exist");
+            }
+
             // Manage topic_subscribe
             if (!fileValuesYaml.topic_subscribe.empty())
             {

diff --git a/chardev/adapter/ChardevManager.cpp b/chardev/adapter/ChardevManager.cpp
@@ -2,6 +2,8 @@
 
 #include "ChardevManager.hpp"
 
+#include <filesystem>
+
 #include "../../util/FileHelper.hpp"
 #include "../../util/Exceptions.hpp"
 
@@ -71,6 +73,11 @@ void ChardevManager::InitAdaptersFromConfigFile(const YAML::Node& configFile,
     for (auto chardevYaml : chardevYAMLConfigs)
     {
         const std::string pathToFile = chardevYaml.path;
+
+        if (!std::filesystem::exists(pathToFile))
+        {
+            throw std::runtime_error("file " + pathToFile + " does not exist");
+        }
 
         std::string pathToFile_ = pathToFile;
         for(std::size_t i = 0; i < pathToFile_.size(); ++i)

diff --git a/gpio/adapter/GpioManager.cpp b/gpio/adapter/GpioManager.cpp
@@ -3,6 +3,7 @@
 #include "GpioManager.hpp"
 
 #include <thread>
+#include <filesystem>
 #include <sys/ioctl.h>
 #include <linux/gpio.h>
 
@@ -71,6 +72,11 @@ void GpioManager::InitAdaptersFromConfigFile(const YAML::Node& configFile,
         std::vector<Util::DataYAMLConfig> gpioYAMLConfigs;
         GetYamlConfig(chipNode, gpioYAMLConfigs, chipPath);
 
+        if (!std::filesystem::exists(chipPath))
+        {
+            throw std::runtime_error("GPIO chip " + chipPath + " does not exist");
+        }
+
         const auto chipName = chipPath.substr(chipPath.find_last_of('/') + 1);
 
         auto ioc = std::make_unique<Ioc>();