Platform support #152
Open
Platform support #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues: SILKIT-1645 Signed-off-by: Jan Kraemer <[email protected]>
MariusBgm
reviewed
Nov 29, 2024
Comment on lines
+156
to
+158
| * - No Tier | ||
| - Not supported, not known whether SIL Kit even builds for this platform. Anything not in `Tier 1` or `Tier 2` | ||
|
|
There was a problem hiding this comment.
Suggested change
| * - No Tier | |
| - Not supported, not known whether SIL Kit even builds for this platform. Anything not in `Tier 1` or `Tier 2` |
I'd drop the No Tier row. And add a sentence on how we deal with other targets.
Comment on lines
+145
to
+148
| SIL Kit provides 3 targets of plfatform support. A platform hereby is defined by | ||
| a architecture-operating compiler ABI triple. An example would be | ||
| `x86_64-ubuntu20.04-clang`, which is currently our default target for Linux | ||
| builds. |
There was a problem hiding this comment.
Suggested change
| SIL Kit provides 3 targets of plfatform support. A platform hereby is defined by | |
| a architecture-operating compiler ABI triple. An example would be | |
| `x86_64-ubuntu20.04-clang`, which is currently our default target for Linux | |
| builds. | |
| SIL Kit provides two tiers of platform support: | |
| 1. Officially build, continuously tested targets for which we provide binary packages, and | |
| 2. Targets for which we have (limited) build support but which are not continuously tested and no packages are provided from us. | |
| A platform hereby is defined by a target triplet, consisting of the CPU architecture, operating system and compiler. | |
| An example would be `x86_64-ubuntu20.04-clang`, which is currently our default target for Linux | |
| packages. | |
| SIL Kit should compile and run on any POSIX platform. | |
| If you have feedback for different targets or platforms please report via the GitHub issues, thanks! | |
| A target may be upgraded to `Tier 1` once we have continuous testing for it in place and we have binary packages available for it. |
I'd slightly reword it, and add how we deal with other targets.
Comment on lines
+166
to
+169
| * - x86_64-windows-msvc | ||
| - X86 64bit Windows builds with MSVC ABI | ||
| * - x86_32-windows-msvc | ||
| - X86 32bit Windows builds with MSVC ABI |
There was a problem hiding this comment.
Not sure if the GNU triple makes sense for windows.
should we rather state the MSVC version and toolset version used?
E.g,
MSVC 19 with toolset 14.1
Or the human readable strings, MSVC 19 targeting VS2017
| * - Platform | ||
| - Notes | ||
| * - x86_64-nto-qnx710 | ||
| - X86 64bit QNX 7.1 RTOS builds |
There was a problem hiding this comment.
We should probably add a comment that we're planning on integrating CI/CT for some targets, like for QNX.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Add the platform support info for SIL Kit
Developer checklist (address before review)