-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update basic
example to ESLint v9 and Flat Configurations.
#9501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
the
area: examples
Improvements or additions to examples
label
Nov 22, 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Skipped Deployments
|
anthonyshew
commented
Nov 22, 2024
anthonyshew
commented
Nov 22, 2024
anthonyshew
commented
Nov 22, 2024
This was referenced Nov 22, 2024
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
anthonyshew
changed the title
Update basic example to ESLint v9 and Flat Configurations.
Update Nov 22, 2024
basic
example to ESLint v9 and Flat Configurations.
anthonyshew
changed the title
Update
chore: Update Nov 22, 2024
basic
example to ESLint v9 and Flat Configurations.basic
example to ESLint v9 and Flat Configurations.
anthonyshew
changed the title
chore: Update
chore: update Nov 22, 2024
basic
example to ESLint v9 and Flat Configurations.basic
example to ESLint v9 and Flat Configurations.
Closed
vincenthsh
reviewed
Nov 23, 2024
Co-authored-by: vincenthsh <[email protected]>
tknickman
approved these changes
Nov 25, 2024
chris-olszewski
approved these changes
Nov 25, 2024
NicholasLYang
approved these changes
Nov 25, 2024
This was referenced Nov 25, 2024
anthonyshew
added a commit
that referenced
this pull request
Nov 25, 2024
### Description I left some unneeded dependencies behind when I was upgrading this example in #9501. This gets rid of them. ### Testing Instructions I've verified that ESLint violations get reported as expected in my editor and when running `turbo lint`. You can also clone with `npx create-turbo@canary -e https://github.com/vercel/turborepo/tree/shew-0f804/examples/basic basic-eslint-9` to have a play with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR converts our
basic
example to ESLint v9 with Flat Configurations.I may have a few gray hairs now, but I'm very excited for the community to have this.
Testing Instructions
Use
npx create-turbo@canary -e https://github.com/vercel/turborepo/tree/shew-409f3/examples/basic basic-eslint-9
to try it out.eslint-config-turbo
, most importantly!