Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update basic example to ESLint v9 and Flat Configurations. #9501

Merged
merged 11 commits into from
Nov 25, 2024

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Nov 22, 2024

Description

This PR converts our basic example to ESLint v9 with Flat Configurations.

I may have a few gray hairs now, but I'm very excited for the community to have this.

Testing Instructions

Use npx create-turbo@canary -e https://github.com/vercel/turborepo/tree/shew-409f3/examples/basic basic-eslint-9 to try it out.

  • Pull it down, make sure you see diagnostics where you'd expect in your editor. Including for eslint-config-turbo, most importantly!
  • I know the diff is big, but there may be vestigials from my experimenting lying around. Please use a finely toothed comb! (I've looked myself but the more eyes, the better.)

@anthonyshew anthonyshew requested a review from a team as a code owner November 22, 2024 20:44
@turbo-orchestrator turbo-orchestrator bot added the area: examples Improvements or additions to examples label Nov 22, 2024
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2024 4:08am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2024 4:08am
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 4:08am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 4:08am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 4:08am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 4:08am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 4:08am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 4:08am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 4:08am

Copy link

socket-security bot commented Nov 22, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@typescript-eslint/[email protected] None +7 4.56 MB bradzacher, jameshenry
npm/@typescript-eslint/[email protected] None +5 1.44 MB bradzacher, jameshenry
npm/[email protected] environment Transitive: filesystem +16 5.2 MB eslintbot
npm/[email protected] None 0 176 kB sindresorhus
npm/[email protected] None +6 1.81 MB jameshenry

🚮 Removed packages: npm/[email protected]

View full report↗︎

@anthonyshew anthonyshew changed the title Update basic example to ESLint v9 and Flat Configurations. Update basic example to ESLint v9 and Flat Configurations. Nov 22, 2024
@anthonyshew anthonyshew changed the title Update basic example to ESLint v9 and Flat Configurations. chore: Update basic example to ESLint v9 and Flat Configurations. Nov 22, 2024
@anthonyshew anthonyshew changed the title chore: Update basic example to ESLint v9 and Flat Configurations. chore: update basic example to ESLint v9 and Flat Configurations. Nov 22, 2024
@anthonyshew anthonyshew mentioned this pull request Nov 22, 2024
@anthonyshew anthonyshew merged commit b00eea2 into main Nov 25, 2024
37 checks passed
@anthonyshew anthonyshew deleted the shew-409f3 branch November 25, 2024 16:30
anthonyshew added a commit that referenced this pull request Nov 25, 2024
### Description

I left some unneeded dependencies behind when I was upgrading this
example in #9501. This gets rid of them.

### Testing Instructions

I've verified that ESLint violations get reported as expected in my
editor and when running `turbo lint`. You can also clone with `npx
create-turbo@canary -e
https://github.com/vercel/turborepo/tree/shew-0f804/examples/basic
basic-eslint-9` to have a play with it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Improvements or additions to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants