feat(verified_contracts-values) - add verified_contracts creation and runtime values constraints
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimrakhimov
force-pushed
the
rimrakhimov/values-constraints
branch
from
b438373 to
ec1f649
Compare
rimrakhimov
force-pushed
the
rimrakhimov/values-constraints
branch
from
ec1f649 to
657300e
Compare
rimrakhimov
changed the base branch from
rimrakhimov/artifacts-constraints
to
master
rimrakhimov
force-pushed
the
rimrakhimov/values-constraints
branch
from
657300e to
22d04c7
Compare
rimrakhimov
changed the title
verified_contracts creation and runtime values constraintsverified_contracts creation and runtime values constraints
rimrakhimov
changed the title
verified_contracts creation and runtime values constraintsverified_contracts creation and runtime values constraints
kuzdogan
reviewed
Sep 5, 2024
There was a problem hiding this comment.
1 comment, and about that, we do allow submitting contracts without creation match right? In my mind it was that we require a creation match but runtime match was optional. What I can see from the schema now, is it can be either runtime or creation.
Otherwise great tests again. Thank you
|
As far as I remember, we've agreed upon at least one match without any difference if it is creation or runtime one. For example, for contracts deployed in genesis there will be no creation matches, but runtime only |
kuzdogan
approved these changes
Sep 9, 2024
…ding to json schema
…llProtection field
rimrakhimov
force-pushed
the
rimrakhimov/values-constraints
branch
from
d5c4d8e to
facb73a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check that only allowed keys are used inside
verified_contracts.creation_valuesandverified_contracts.runtime_values. Allows for keys not to be present in the object.Adds internal constraints for the values according to json-schema (checks that values are valid hexes and have correct lengths)