Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/e2e #613

Closed
wants to merge 7 commits into from
Closed

Tests/e2e #613

wants to merge 7 commits into from

Conversation

erikyo
Copy link
Collaborator

@erikyo erikyo commented Apr 1, 2024

DO NOT MERGE! yet :)

Why?
I endeavored to improve the coverage for this module. However, employing Jest proved to be rather intricate, necessitating the addition of numerous modules to simulate the DOM. At this juncture, I pondered: "Why not opt for end-to-end tests?" This approach would assuredly be more straightforward and afford us greater control, both functionally and visually, over the lazy load behavior.

What?

  • Added E2E testing with playwright
  • Moved the jest tests into ./tests/unit

This is a draft:
to be checked - coverage - CI - etc

@erikyo
Copy link
Collaborator Author

erikyo commented Apr 2, 2024

has been continued in the dev branch

@erikyo erikyo closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant