-
-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds the browserlist configuration #615
Conversation
Isn't this the same as not having a browserslist config? I would expect so... What's the |
Seems not, the output is a bit different with and without those lines # with browserlist
du -h
24K ./esm
128K .
# without browserlist
du -h
24K ./esm
136K . As a test case without browserlist i can find in the code "var myVariable" and with browserlist the output displays "const variable", so i guess to have it or to not have it changes something in the default babel config. |
Cool, then better add it explicitly and maybe adapt it later to your supported browsers |
Yes we will, the only thing is that I want to make sure that in older versions of safari (e.g. 12) everything still works as before because with the default browserslist configuration the last supported are:
|
I have a browserstack account if we need to test on older versions of any browser. |
And they have an SDK for Playwright |
In the screenshots is why the code is shorter with @erikyo's addition.
This code looks solid to me. |
And ES6 is widely supported nowadays, see the can I use table (or the screenshot) |
And as I stated in this section of the readme, users who need to support legacy browsers can always use version 17.9.0. There are 3.7 Billion users / month downloading version 10.19.0, so... ¯_(ツ)_/¯ |
Yep the browserslist repository is crafted very well and the default setting should be something like
which is why I don't think anyone will complain 😇 Just we need to make sure to update to the last version the current database using:
before build the new "versions" and automatically babel will use the correct polyfills according to the current world standards |
Released |
I added this to the build steps I follow before releasing.
Thanks Erik |
Adds the configuration required for babel/browserlist.
This very simple change, however, is worth about 1/8 less code in the build
close #614