Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an action for linting and releasing helm chart #364

Closed
wants to merge 2 commits into from

Conversation

allanger
Copy link

Hi,

I've added a GitHub action that is linting helm chart on each pushed commit and releasing a new version helm chart automatically on each new push to the master branch.

The linter job is checking whether the chart is changed, and in case it is, the linter expects the versions to be bumped. That means that all the changes to chart will be delivered to its users right away.

The releaser action is adding the helm chart archive to github releases and creating an index file in the branch that is used as a github pages branch (currently, hardcoded to gh-pages)

Since it's rather a worklfow change, I wouldn't expect you to actually merge it, cause you probably have you own workflow, and it's something new to maintain, but I think that many users of you chart would benefit from having an ability to get latest changes when they are merged to master instead of waiting for the new release. So if you consider merging it I can support this action for a time being

Thanks

I've added a GitHub action that is linting helm chart on each pushed
commit and releasing a new version helm chart automatically on each new
push to the `master` branch.

The linter job is checking whether the chart is changed, and in case it
is, the linter expects the versions to be bumped. That means that all
the changes to chart will be delivered to its users right away.
@ioolkos
Copy link
Contributor

ioolkos commented Sep 19, 2023

@allanger Let me think about what to do with it. But firstly, thanks for your contribution.

@allanger
Copy link
Author

I think that I've configured the workflow wrong, the "Release" step shouldn't be triggered by PR event, hopefully, now it's better (after 839de24)

@ioolkos I see that you're using Travis, I guess the whole workflow can be just moved there

@ioolkos
Copy link
Contributor

ioolkos commented Sep 20, 2023

We're off Travis and use an internal Action flow. But this just made me realize that the Travis Github app is still installed, getting triggered but doing nothing.

@allanger allanger closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants