Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE when only batchHandler is specified #281

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix NPE when only batchHandler is specified #281

wants to merge 1 commit into from

Conversation

Strainy
Copy link

@Strainy Strainy commented Nov 27, 2024

Fixes #279.

@Strainy
Copy link
Author

Strainy commented Nov 27, 2024 •
edited
Loading

Awaiting approval on my end before signing ECA.

@Strainy Strainy mentioned this pull request Nov 27, 2024
Open
Strainy
Strainy commented Nov 27, 2024
View reviewed changes
src/test/java/io/vertx/kafka/client/tests/ConsumerTestBase.java
@@ -1332,7 +1332,8 @@ public void testConsumerBatchHandler(TestContext ctx) throws Exception {
String consumerId = topicName;
Async batch1 = ctx.async();
AtomicInteger index = new AtomicInteger();
int numMessages = 500;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resulted in a single iteration of the consumer loop, which effectively hid the NPE. I've bumped numMessages such that it actually triggers the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE when using batchHandler
1 participant
@Strainy