Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extensions #245

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Update extensions #245

merged 3 commits into from
Apr 15, 2024

Conversation

roypaulin
Copy link
Collaborator

@roypaulin roypaulin commented Apr 11, 2024

The following changes were made:

  • Update the extensions to work on jupyterlab4.0.x
  • Update vertica-start cmd so that now if verticapylab is already running, it will open it in the browser
  • Fix the TEST_MODE on MacOS

@roypaulin roypaulin self-assigned this Apr 12, 2024
@roypaulin
Copy link
Collaborator Author

@mail4umar can intensively test this? I will like you to build the image and and try the commands and report any errors so that I can fix them.

@roypaulin
Copy link
Collaborator Author

image
This is what it looks like!

@roypaulin
Copy link
Collaborator Author

@oualib I was not able to add back the vsql/admintools buttons. I tried to put all of them in a single extensions but it did not work. Here are our options:

  • Add them later. For that we would need to create another extension. I don't think it is worth the effort as it will balloon the container, without offering much.
  • Users can still use vsql/admintools through the Terminal button in jupyterlab all the need is to click on the button and when the terminal open up, run vsql/admintools
  • Create a separate extension but, but not include it in the image, users could install it at run time if they want. We cannot put everything in the image
  • Never put them back. I think we should leverage voila to build more web-based extensions and just add buttons to redirect to those web pages. This approach is light and relies on notebooks that don't need to be stored in the image, so it can really scale.

@roypaulin roypaulin requested a review from mail4umar April 12, 2024 15:20
@mail4umar
Copy link
Collaborator

@roypaulin Why are we still keeping the folder "extensions"?

@roypaulin
Copy link
Collaborator Author

@roypaulin Why are we still keeping the folder "extensions"?

It is just needed as a code reference to write the extensions in extensions-v2, after this PR it can be removed.

@mail4umar mail4umar merged commit 149afcd into main Apr 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants