[build] Add pr-jobs-linux check #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fredia Would you please share the diff of this scripts with those in rocksdb repo? |
Sure, I updated the diff in the description, PTAL. |
|
@fredia Great job! Is it possible to add CI for macosx? |
Added |
|
This closes #6 |
fredia
added a commit
to fredia/ForSt
that referenced
this pull request
Sep 26, 2024
(cherry picked from commit 0d7fea8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add pr-jobscheck, pr-jobs.yml is a simplified version of https://github.com/facebook/rocksdb/blob/main/.github/workflows/pr-jobs.yml, which only contains some checks on basic linux and macOS.
Since we are using the shared github machine as the runner, there are some minor differences:
build-linuxandbuild-linux-releaserequire gflags to be installed first.build-linuxare decreased from 32 to 8, to prevent accidental cancellation.Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.