-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[env] Implement all methods of env_flink #13
Conversation
21c0b9a
to
053b7f4
Compare
4cd761c
to
21de72b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I left some comments. PTAL
3cf7cf9
to
684cecb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. PTAL my comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM.
As we discussed offline, we should add necessary UT tests for these filesystem interface later.
2990c44
to
8f81336
Compare
(cherry picked from commit 7c0c8da)
(cherry picked from commit a5c920d)
What is the purpose of the change
Implemet all methods of env_flink
Brief change log
Verifying this change
This change will be tested in Java side after FlinkEnv is ready.