Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up the repo definition from github when trying to install the ve… #32397

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

aressem
Copy link
Member

@aressem aressem commented Sep 13, 2024

…spa RPM.

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@aressem aressem requested a review from glebashnik September 13, 2024 07:41
@@ -24,7 +24,7 @@ jobs:
run: |
dnf list llvm-libs --showduplicates
dnf install -y dnf-plugins-core
dnf config-manager --add-repo https://copr.fedorainfracloud.org/coprs/g/vespa/vespa/repo/epel-8/group_vespa-vespa-epel-8.repo
dnf -y config-manager --add-repo https://raw.githubusercontent.com/vespa-engine/vespa/master/dist/vespa-engine.repo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should update documentation and all places where that repository is mentioned?

I found some:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general yes. But old blogs and references to CentOS 7 should be left alone.

@aressem
Copy link
Member Author

aressem commented Sep 16, 2024

PTAL, @glebashnik

@aressem aressem requested a review from hmusum September 17, 2024 12:21
@aressem aressem merged commit 01348b1 into master Sep 17, 2024
4 checks passed
@aressem aressem deleted the aressem/fix-rpm-install branch September 17, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants