Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve PS 6/7 compatibility issue in 'Fun with GUIs' advice snippet #419

Merged
merged 1 commit into from
Oct 25, 2020
Merged

Resolve PS 6/7 compatibility issue in 'Fun with GUIs' advice snippet #419

merged 1 commit into from
Oct 25, 2020

Conversation

johnheusinger
Copy link
Contributor

PR Summary

I tried out the advice in the 'Fun with GUIs' snippet and noticed the following problems:

  • $GUIExample.BackColor = 'Blue' works in PS 5 but not 6/7.
  • Variable $BackgroundImage is initialized but never referenced/used

Context

Relates to #260

Changes

  • Removed references to background image from code and comments
  • Adjusted background color setting for compatibility
  • Minor spelling/formatting tweaks

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

vexx32
vexx32 approved these changes Oct 25, 2020
View reviewed changes
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up! 😊

@vexx32 vexx32 added Category-Advice 🗨️ Related to Advice cmdlets or library hacktoberfest-accepted PRs that have been accepted for Hacktoberfest labels Oct 25, 2020
@vexx32 vexx32 merged commit 378089f into vexx32:main Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vexx32 vexx32 vexx32 approved these changes

@steviecoaster steviecoaster Awaiting requested review from steviecoaster steviecoaster is a code owner

Assignees
No one assigned
Labels
Category-Advice 🗨️ Related to Advice cmdlets or library hacktoberfest-accepted PRs that have been accepted for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnheusinger @vexx32