Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up building the distance index without distances #4446

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

xchang1
Copy link
Contributor

@xchang1 xchang1 commented Nov 14, 2024

Changelog Entry

To be copied to the draft changelog by merger:

  • speed up building the distance index without distances

Description

@xchang1
Copy link
Contributor Author

xchang1 commented Nov 14, 2024

This should help #4420

@xchang1
Copy link
Contributor Author

xchang1 commented Nov 18, 2024

I tested this and it should be fine to merge once the CI tests finish

@adamnovak
Copy link
Member

I think CI was never started since this came from an external repo. I've pulled 87df7fc into distanceless-distance-index in the main vgteam repo so the tests should actually run now.

@xchang1
Copy link
Contributor Author

xchang1 commented Nov 19, 2024

I forgot about that. Thanks, Adam!

@xchang1 xchang1 merged commit c9e7e2b into vgteam:master Nov 19, 2024
2 checks passed
@xchang1 xchang1 deleted the distanceless-distance-index branch November 19, 2024 08:46
@xchang1 xchang1 mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants