Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frog protocols 🐸 #93

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

Conan-Kudo
Copy link

Fixes #92

@PolyMeilex
Copy link
Contributor

FYI you have to add protocols to src/data/protocol-registry.ts without that this MR only adds a frog category.

@Conan-Kudo
Copy link
Author

I know, I'm working through it. I just wanted the draft up asap.

@@ -41,6 +41,11 @@ const cosmicProtocolsUnstableBadgeTheme: BadgeTheme = {
backgroundColor: 'bg-red-100',
}

const frogProtocolsBadgeTheme: BadgeTheme = {
textColor: 'text-red-800',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should probably use text-green-800. the difference won't be very noticeable tbf but its just a minor nitpick

Copy link
Contributor

@PolyMeilex PolyMeilex Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, green seems kinda better
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want it to use the same colors as wayland stable protocols.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use one of the other color palettes from Tailwind

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random idea, perhaps lime bg-lime-400 text-lime-900

image

(btw core is green, stable protocols are actually blue)
(I swear I'm not trying to turn this into a discussion about colors of bike sheds 😄 )

@TheESN
Copy link

TheESN commented Oct 22, 2024

Looks like this PR is stalled. Is it planned to continue work on it?

@Conan-Kudo
Copy link
Author

Sorry, I haven't had time, I've been swamped with other things lately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding frog protocols
4 participants