Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Viash v0.8.2 #10

Merged
merged 11 commits into from
Jan 17, 2024
Merged

Upgrade to Viash v0.8.2 #10

merged 11 commits into from
Jan 17, 2024

Conversation

tverbeiren
Copy link
Member

No description provided.

Copy link
Contributor

@DriesSchaumont DriesSchaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! :+1 Some comments and suggestions 🙂

src/workflows/demo_pipeline/config.vsh.yaml Outdated Show resolved Hide resolved
src/workflows/demo_pipeline/config.vsh.yaml Outdated Show resolved Hide resolved
src/workflows/demo_pipeline/config.vsh.yaml Outdated Show resolved Hide resolved
src/workflows/demo_pipeline/main.nf Outdated Show resolved Hide resolved
@tverbeiren
Copy link
Member Author

Since the actual Nextflow pipeline of the template is not shown in the guide, I will refactor it to contain the state management arguments explicitly.

@tverbeiren
Copy link
Member Author

Based on the suggestion from Robrecht earlier today, do you agree @DriesSchaumont to rewrite the template workflow to remove the ability to use globs and work with a YAML file as input?

@tverbeiren
Copy link
Member Author

The latest commit allows running from a 'sample sheet' as follows:

nextflow run target/nextflow/template/workflow/main.nf \
  -with-docker \
  -resume \
  --publish_dir output \
  --param_list resources_test/input.csv \

@dorien-er dorien-er merged commit 0ad975a into main Jan 17, 2024
6 checks passed
@rcannood rcannood deleted the upgrade/viash_0.8.2 branch July 17, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants