Merge pull request #174 from hansemannn/update-sdk

feat(core): refactor module, fix 28 memory leaks, expose iOS 11 activity types, lint sources
viezel · Nov 10, 2018 · c5d2be1 · c5d2be1
2 parents e6099ba + 166a880
commit c5d2be1
Show file tree

Hide file tree

Showing 28 changed files with 1,298 additions and 1,521 deletions.
diff --git a/.clang-format b/.clang-format
@@ -0,0 +1,96 @@
+---
+# BasedOnStyle:  WebKit
+AccessModifierOffset: -4
+AlignAfterOpenBracket: DontAlign
+AlignConsecutiveAssignments: false
+AlignConsecutiveDeclarations: false
+AlignEscapedNewlinesLeft: false
+AlignOperands:   false
+AlignTrailingComments: false
+AllowAllParametersOfDeclarationOnNextLine: true
+AllowShortBlocksOnASingleLine: false
+AllowShortCaseLabelsOnASingleLine: false
+AllowShortFunctionsOnASingleLine: All
+AllowShortIfStatementsOnASingleLine: false
+AllowShortLoopsOnASingleLine: false
+AlwaysBreakAfterDefinitionReturnType: None
+AlwaysBreakAfterReturnType: None
+AlwaysBreakBeforeMultilineStrings: false
+AlwaysBreakTemplateDeclarations: false
+BinPackArguments: true
+BinPackParameters: true
+BraceWrapping:   
+  AfterClass:      false
+  AfterControlStatement: false
+  AfterEnum:       false
+  AfterFunction:   true
+  AfterNamespace:  false
+  AfterObjCDeclaration: false
+  AfterStruct:     false
+  AfterUnion:      false
+  BeforeCatch:     false
+  BeforeElse:      false
+  IndentBraces:    false
+BreakBeforeBinaryOperators: All
+BreakBeforeBraces: WebKit
+BreakBeforeTernaryOperators: true
+BreakConstructorInitializersBeforeComma: true
+BreakAfterJavaFieldAnnotations: false
+BreakStringLiterals: true
+ColumnLimit:     0
+CommentPragmas:  '^ IWYU pragma:'
+BreakBeforeInheritanceComma: false
+ConstructorInitializerAllOnOneLineOrOnePerLine: false
+ConstructorInitializerIndentWidth: 4
+ContinuationIndentWidth: 4
+Cpp11BracedListStyle: false
+DerivePointerAlignment: false
+DisableFormat:   false
+ExperimentalAutoDetectBinPacking: false
+FixNamespaceComments: false
+ForEachMacros:   [ foreach, Q_FOREACH, BOOST_FOREACH ]
+IncludeCategories: 
+  - Regex:           '^"(llvm|llvm-c|clang|clang-c)/'
+    Priority:        2
+  - Regex:           '^(<|"(gtest|isl|json)/)'
+    Priority:        3
+  - Regex:           '.*'
+    Priority:        1
+IncludeIsMainRegex: '$'
+IndentCaseLabels: false
+IndentWidth:     2
+IndentWrappedFunctionNames: false
+JavaScriptQuotes: Leave
+JavaScriptWrapImports: true
+KeepEmptyLinesAtTheStartOfBlocks: true
+MacroBlockBegin: ''
+MacroBlockEnd:   ''
+MaxEmptyLinesToKeep: 1
+NamespaceIndentation: Inner
+ObjCBlockIndentWidth: 2
+ObjCSpaceAfterProperty: true
+ObjCSpaceBeforeProtocolList: true
+PenaltyBreakBeforeFirstCallParameter: 19
+PenaltyBreakComment: 300
+PenaltyBreakFirstLessLess: 120
+PenaltyBreakString: 1000
+PenaltyExcessCharacter: 1000000
+PenaltyReturnTypeOnItsOwnLine: 60
+PointerAlignment: Right
+ReflowComments:  true
+SortIncludes:    true
+SpaceAfterCStyleCast: false
+SpaceAfterTemplateKeyword: true
+SpaceBeforeAssignmentOperators: true
+SpaceBeforeParens: ControlStatements
+SpaceInEmptyParentheses: false
+SpacesBeforeTrailingComments: 1
+SpacesInAngles:  false
+SpacesInContainerLiterals: true
+SpacesInCStyleCastParentheses: false
+SpacesInParentheses: false
+SpacesInSquareBrackets: false
+Standard:        Cpp11
+TabWidth:        8
+UseTab:          Never
+...
diff --git a/CHANGELOG.txt b/CHANGELOG.txt
diff --git a/Classes/DkNappSocialModule.h b/Classes/DkNappSocialModule.h
@@ -6,37 +6,33 @@
  * and licensed under the Apache Public License (version 2)
  */
 #import "TiModule.h"
-#import <Accounts/Accounts.h>
 #import "TiViewController.h"
+#import <Accounts/Accounts.h>
 
-@interface DkNappSocialModule : TiModule
-<
-UIPopoverControllerDelegate,
-UIPopoverPresentationControllerDelegate
->
-{
-    ACAccountStore* accountStore;
-    CGRect popoverRect;
-	UIPopoverController *popoverController;
-    UIViewController* viewController;
-    id senderButton;
+@interface DkNappSocialModule : TiModule <UIPopoverControllerDelegate, UIPopoverPresentationControllerDelegate> {
+  ACAccountStore *accountStore;
+  CGRect popoverRect;
+  UIPopoverController *popoverController;
+  UIViewController *viewController;
+  id senderButton;
 }
 
-
-@property(nonatomic,readonly) NSNumber *ACTIVITY_FACEBOOK;
-@property(nonatomic,readonly) NSNumber *ACTIVITY_TWITTER;
-@property(nonatomic,readonly) NSNumber *ACTIVITY_WEIBO;
-@property(nonatomic,readonly) NSNumber *ACTIVITY_MESSAGE;
-@property(nonatomic,readonly) NSNumber *ACTIVITY_MAIL;
-@property(nonatomic,readonly) NSNumber *ACTIVITY_PRINT;
-@property(nonatomic,readonly) NSNumber *ACTIVITY_COPY;
-@property(nonatomic,readonly) NSNumber *ACTIVITY_ASSIGN_CONTACT;
-@property(nonatomic,readonly) NSNumber *ACTIVITY_SAVE_CAMERA;
-@property(nonatomic,readonly) NSNumber *ACTIVITY_READING_LIST;
-@property(nonatomic,readonly) NSNumber *ACTIVITY_FLICKR;
-@property(nonatomic,readonly) NSNumber *ACTIVITY_VIMEO;
-@property(nonatomic,readonly) NSNumber *ACTIVITY_AIRDROP;
-@property(nonatomic,readonly) NSNumber *ACTIVITY_TENCENT_WEIBO;
-@property(nonatomic,readonly) NSNumber *ACTIVITY_CUSTOM;
+@property (nonatomic, readonly) NSString *ACTIVITY_FACEBOOK;
+@property (nonatomic, readonly) NSString *ACTIVITY_TWITTER;
+@property (nonatomic, readonly) NSString *ACTIVITY_WEIBO;
+@property (nonatomic, readonly) NSString *ACTIVITY_MESSAGE;
+@property (nonatomic, readonly) NSString *ACTIVITY_MAIL;
+@property (nonatomic, readonly) NSString *ACTIVITY_PRINT;
+@property (nonatomic, readonly) NSString *ACTIVITY_COPY;
+@property (nonatomic, readonly) NSString *ACTIVITY_ASSIGN_CONTACT;
+@property (nonatomic, readonly) NSString *ACTIVITY_SAVE_CAMERA;
+@property (nonatomic, readonly) NSString *ACTIVITY_READING_LIST;
+@property (nonatomic, readonly) NSString *ACTIVITY_FLICKR;
+@property (nonatomic, readonly) NSString *ACTIVITY_VIMEO;
+@property (nonatomic, readonly) NSString *ACTIVITY_AIRDROP;
+@property (nonatomic, readonly) NSString *ACTIVITY_TENCENT_WEIBO;
+@property (nonatomic, readonly) NSString *ACTIVITY_OPEN_IN_IBOOKS;
+@property (nonatomic, readonly) NSString *ACTIVITY_MARKUP_AS_PDF;
+@property (nonatomic, readonly) NSString *ACTIVITY_CUSTOM;
 
 @end