feat: support uWebSocket.js

[rtritto]

Changes/TODO

• disabled cors middleware (enabled by default) in Vite Dev Server: cors middleware, used by Vite, uses isn't compatible with response and request as Request, IncomingMessage, ServerResponse of Node.js; source: https://github.com/vitejs/vite/blob/main/packages/vite/src/node/server/index.ts#L831
• create a createServerResponse.ts file (same as https://github.com/vikejs/vike-node/blob/main/packages/vike-node/src/runtime/adapters/createServerResponse.ts) to bind (replace) the res.writeHead used by Vite middleware https://github.com/vitejs/vite/blob/main/packages/vite/src/node/server/middlewares/base.ts

  res.writeHead = function writeHead(
    statusCode: number,
    statusMessage?: string | OutgoingHttpHeaders | OutgoingHttpHeader[],
    headers?: OutgoingHttpHeaders | OutgoingHttpHeader[]
  ): ServerResponse {
  -  res.statusCode = statusCode
  +  res.writeStatus(statusCode)
    if (typeof statusMessage === 'object') {
      headers = statusMessage
      statusMessage = undefined
    }
    if (headers) {
      Object.entries(headers).forEach(([key, value]) => {
        if (value !== undefined) {
  -        res.setHeader(key, value)
  +        res.writeHeader(key, value)
        }
      })
    }
    return res
  }

• build static files in https://github.com/rtritto/vike-node/blob/uws/packages/vike-node/src/runtime/handler-node-only-uws.ts
• check body in https://github.com/rtritto/vike-node/blob/uws/packages/vike-node/src/runtime/adapters/connectToWebUws.ts

Fix #20

Note: Help and reviews are needed

[rtritto]

FYI @nitedani

[rtritto]

https://github.com/vikejs/vike-node/actions/runs/11464915212/job/31902213911?pr=22

Error: 42.542][/test/vike-node/.prod-uws.test.ts][npm run prod][stderr] ✘ [ERROR] No loader is configured for ".node" files: ../../node_modules/.pnpm/uWebSockets.js@https+++codeload.github.com+uNetworking+uWebSockets.js+tar.gz+442087c0a01bf146_ef5o3ypzxljf3ryz2pfwb3ukxu/node_modules/uWebSockets.js/uws_linux_arm_108.node

What should we use to load native Node (.node) modules?

Some alternatives:

• Support for native .node modules evanw/esbuild#1051 (comment)
• Support for native .node modules evanw/esbuild#1051 (comment)
• https://www.npmjs.com/package/vite-plugin-node
• https://www.npmjs.com/package/@liuli-util/vite-plugin-node
• add esbuild: { loader: { '.node': 'file' } } to /test/vike-node/vite.config.ts

There is a vike plugin to do that?

FYI @brillout @nitedani

[rtritto]

https://github.com/vikejs/vike-node/actions/runs/11464915212/job/31902213911?pr=22

Error: 42.542][/test/vike-node/.prod-uws.test.ts][npm run prod][stderr] ✘ [ERROR] No loader is configured for ".node" files: ../../node_modules/.pnpm/uWebSockets.js@https+++codeload.github.com+uNetworking+uWebSockets.js+tar.gz+442087c0a01bf146_ef5o3ypzxljf3ryz2pfwb3ukxu/node_modules/uWebSockets.js/uws_linux_arm_108.node

What should we use to load native Node (.node) modules?

Some alternatives:

• Support for native .node modules evanw/esbuild#1051 (comment)

• Support for native .node modules evanw/esbuild#1051 (comment)

• https://www.npmjs.com/package/vite-plugin-node

• https://www.npmjs.com/package/@liuli-util/vite-plugin-node

• add esbuild: { loader: { '.node': 'file' } } to /test/vike-node/vite.config.ts

There is a vike plugin to do that?

FYI @brillout @nitedani

I fixed using uws-pack that uses dynamic import to import the current Node.js native module.

Now /test/vike-node/.dev-uws.test.ts got timeout: https://github.com/vikejs/vike-node/actions/runs/11485389164/job/31965334594?pr=22

[brillout]

I'll have a look at this PR after I'm done with my current backlog. ETA soon.

[rtritto]

Note: this PR can be used (generalized common factor) for all HTTP server frameworks that didn't use Node.js objects (Request, IncomingMessage, ServerResponse)

[brillout]

@rtritto Thank you for your PR and the ping. It would indeed be great to support uWebSockets. In #16 we're starting using universal-middleware for vike-node. In other words: some(/most?) of the code in this PR would need to be moved to universal-middleware.

Note

In case you're curious: the vision is to have powerful Vike extensions that can fully integrate with each other automatically (with eject if the user wishes more control).

@magne4000 WDYT? On one hand it would quite nice to support uWebSockets and on the other hand if it slows us down too much then maybe it isn't worth it.

[magne4000]

uWebSockets would indeed need to be integrated into universal-middleware instead of vike-node. @rtritto perhaps that's something you'd be willing to try?

[rtritto]

@magne4000 I don't have (yet) the knowledge to create a new adapter for universal-middleware; as my initial analysis, @universal-middleware/core needs to be adapted (tell me if I'm wrong).

Maybe @hattip/adapter-uwebsockets can help.

Anyway you can start a PR and then ping me or ask for reviews or help.

[brillout]

In the meantime, let's close this PR in favor of a potentially upcoming universal-middleware PR. Thanks again @rtritto for the groundwork 💯

[magne4000]

@magne4000 I don't have (yet) the knowledge to create a new adapter for universal-middleware; as my initial analysis, @universal-middleware/core needs to be adapted (tell me if I'm wrong).

Probably not. Creating a new @universal-middleware/uwebsockets should be enough.

I'll let you know when I'll start working on it, but it's not on my priority list right now.