Skip to content

Commit

Permalink
Merge branch 'main' of https://github.com/vikejs/vike-solid into phon…
Browse files Browse the repository at this point in the history
…zammi/fix-123
  • Loading branch information
phonzammi committed Sep 27, 2024
2 parents d2fb3be + 1a4484f commit 6abb0a2
Show file tree
Hide file tree
Showing 10 changed files with 28 additions and 28 deletions.
6 changes: 3 additions & 3 deletions examples/full/.testRun.ts
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,9 @@ async function ensureWasClientSideRouted(pageIdFirst: `/pages/${string}`) {
}
function findFirstPageId(html: string) {
expect(html).toContain('<script id="vike_pageContext" type="application/json">');
expect(html).toContain("_pageId");
expect(html.split("_pageId").length).toBe(2);
const match = partRegex`"_pageId":"${/([^"]+)/}"`.exec(html);
expect(html).toContain('"pageId"');
expect(html.split('"pageId"').length).toBe(2);
const match = partRegex`"pageId":"${/([^"]+)/}"`.exec(html);
expect(match).toBeTruthy();
const pageId = match![1];
expect(pageId).toBeTruthy();
Expand Down
2 changes: 1 addition & 1 deletion examples/full/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"dependencies": {
"node-fetch": "^3.3.2",
"solid-js": "^1.8.22",
"vike": "^0.4.195",
"vike": "^0.4.197",
"vike-solid": "workspace:*"
},
"devDependencies": {
Expand Down
5 changes: 0 additions & 5 deletions examples/full/pages/stardust/+Layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@ function Layout(props: FlowProps) {
);
}

function Link(props: any) {
// We set `keep-scroll-position` to tell Vike to preserve the current scroll position
return <a keep-scroll-position="" style={{ marginRight: 10, ...props.style }} {...props} />;
}

function Counter() {
const [count, setCount] = createSignal(0);
return (
Expand Down
3 changes: 1 addition & 2 deletions examples/full/pages/starship/+Layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ function Layout(props: FlowProps) {
}

function Link(props: any) {
// We set `keep-scroll-position` to tell Vike to preserve the current scroll position
return <a keep-scroll-position="" style={{ marginRight: 10, ...props.style }} {...props} />;
return <a style={{ marginRight: 10, ...props.style }} {...props} />;
}

function Counter() {
Expand Down
6 changes: 6 additions & 0 deletions examples/full/pages/starship/+config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import type { Config } from "vike/types";

export default {
// https://vike.dev/keepScrollPosition
keepScrollPosition: true,
} satisfies Config;
2 changes: 1 addition & 1 deletion examples/minimal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
},
"dependencies": {
"solid-js": "^1.8.22",
"vike": "^0.4.195",
"vike": "^0.4.197",
"vike-solid": "workspace:*"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion examples/solid-query/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"@tanstack/solid-query": "^5.56.2",
"node-fetch": "^3.3.2",
"solid-js": "^1.8.22",
"vike": "^0.4.195",
"vike": "^0.4.197",
"vike-solid": "workspace:*",
"vike-solid-query": "workspace:^"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/vike-solid-query/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"rollup-plugin-dts": "^6.1.1",
"solid-js": "^1.8.22",
"typescript": "^5.6.2",
"vike": "^0.4.196",
"vike": "^0.4.197",
"vike-solid": "workspace:*"
},
"typesVersions": {
Expand Down
2 changes: 1 addition & 1 deletion packages/vike-solid/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"solid-js": "^1.8.22",
"tslib": "^2.7.0",
"typescript": "^5.6.2",
"vike": "^0.4.196",
"vike": "^0.4.197",
"vite": "^5.4.7"
},
"exports": {
Expand Down
26 changes: 13 additions & 13 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 6abb0a2

Please sign in to comment.