Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vike-solid-query): remove unused vike-solid peer dependency #121

Closed

Conversation

rtritto
Copy link
Contributor

@rtritto rtritto commented Sep 14, 2024

vike-solid-query use only the dependencies @tanstack/solid-query and solid-js in /packages/vike-solid-query/src/QueryBoundary.tsx

Related #116 (comment)

@magne4000
Copy link
Member

As noted in the README:

The vike-solid-query extension requires vike-solid.

So keeping this package in peerDependencies improves the chances that one does not forget to install it.

@magne4000 magne4000 closed this Sep 14, 2024
@rtritto
Copy link
Contributor Author

rtritto commented Sep 14, 2024

This package is generic and can be used without vite and vike in any project that use solid-js

@phonzammi
Copy link
Member

I think it's okay for now. We'll add more specifics for use with vike-solid later.

@rtritto
Copy link
Contributor Author

rtritto commented Sep 14, 2024

This package is generic and can be used without vite and vike in any project that use solid-js

@brillout what do you think about?

By this way, minimal dependencies are installed.

In the future, @tanstack/solid-query can be removed/replaced because it's used only for types.

@rtritto rtritto deleted the solid-query-remove-unused-peer-dep branch September 15, 2024 10:20
@rtritto
Copy link
Contributor Author

rtritto commented Sep 15, 2024

I'm wrong, vike-solid and @tanstack/solid-query are used in /vike-solid-query/integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants