Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ESLint with:
typescript-eslint
eslint-plugin-solid
FIX/TODO
/vike-solid/packages/vike-solid/helpers/clientOnly.tsx
24:37 warning This function should be passed to a tracked scope (like createEffect) or an event handler because it contains reactivity, or else changes will be ignored solid/reactivity
31:12 warning For proper analysis, a variable should be used to capture the result of this function call solid/reactivity
/vike-solid/packages/vike-solid/hooks/usePageContext.tsx
18:40 warning The reactive variable 'props.pageContext' should be used within JSX, a tracked scope (like createEffect), or inside an event handler function, or else changes will be ignored solid/reactivity
CI/workflows
pnpm lint