Changes to address issues and support NetworkServer integration #90
Conversation
…ts-1 branch. Still compatible with LosslessSwitcherRemote iOS app.
receiveClientMessage now gets the size from the client and reads the data based on that to accommodate different client.maximumDatagramSize limits. sendServerResposne now calculates the data payload size and prepends that to the ServerResponse. New support for .toggleBitDepthDetection, .setDeviceSampleRate/.setDeviceBitDepth with ASBD formats, .setCurrentToDetected ResponseData now includes currentBitDepth, detectedBitDepth, bitDepthDetectionEnabled, sampleRatesForCurrentBitDepth, bitDepthsForCurrentSampleRate, timeStamp cleanupInactiveConenction now tries to cancel failed and closed connections, rather than just removing everything thats not .ready. CodableAudioStreamBasicDescription struct for sending/receing ASBD format arrays. ClientRequest now supports .toggleBitDepthDetection, .setDeviceSampleRate/.setDeviceBitDepth with ASBD formats. ClientMessage now has a timeStamp. OutputDevices - updateClient() calls where appropriate. AppDelegate - updateBitDepthDetectionMenuItemState - just like auto switch
While I have yet to try the remote features, I do think that this is really cool. Maybe as a v2.0? Right now I will probably consolidate what's good and bad about all the 9 betas released, and make an actual release of v1.1 before anything else, though. |
|
I encourage you to consolidate and move forward with what you think works the best. I've focused my effort on the iOS companion app and network server without doing much of anything for the actual frequency/bitrate detection. In my use case I predominantly leave the auto-switch off and enjoy being able to change the settings remotely. |
It appears that Xcode is incorrectly attempting to load Network.framework from PrivateFrameworks rather than regular frameworks directory
fix build bug due to private framework conflicts
|
|
||
| The opposite happens, when the next track happens to have a lower sample rate. | ||
| <img width="252" alt="app screenshot, with new display elements for Current and Detected frequencies, Set Rate to Current and Auto Swithing toggle" src="https://user-images.githubusercontent.com/11642124/231385169-37cf4e14-ae31-4cdb-87bb-5fb66aaa263b.png"> |
There was a problem hiding this comment.
This is a bit odd... not sure how permanent those are. Maybe that should be commited into the repo instead?
NetworkServer - establishes a bonjour listener and accepts connections from iOS clients running the companion iOS app LosslessSwitcherRemote:
https://github.com/Robertsmania/LosslessSwitcherRemote
That may understandably be too much to consider pulling into the main LosslessSwitcher project. But other changes address these issues and can be taken individually:
Show both current and detected in menu bar and dropdown #89
#89
Manual set current to detected #88
#88
Setting to toggle auto-switch #87
#87
Display Bit Depth in addition to Sample Rate #86
#86
Manual bit depth override in menu - already in 44
Build 14 still switches Bit Depth when disabled #79
#79
Manual sample rate override in menu #44
#44
Bit depth not changing #2
#2