Add detekt and fix detected issues (#4)

* Add detekt and fix all issues * Remove spread operator * Add lint check together with detekt
vinted · May 12, 2020 · 38c719d · 38c719d
1 parent 7bb85dc
commit 38c719d
Show file tree

Hide file tree

Showing 8 changed files with 686 additions and 28 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -20,3 +20,7 @@ jobs:
     - stage: build
       name: build
       script: ./gradlew build
+    - stage: detekt & lint
+      name: detekt & lint
+      script: ./gradlew detekt lint
+
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -17,3 +17,14 @@ allprojects {
         maven(url = "https://jitpack.io")
     }
 }
+
+plugins {
+    id("io.gitlab.arturbosch.detekt").version(Versions.DETEKT_RUNTIME)
+}
+
+detekt {
+    buildUponDefaultConfig = true
+    parallel = true
+    config = files("${project.rootDir}/detekt/config.yml")
+    input = files(projectDir)
+}
diff --git a/buildSrc/src/main/kotlin/Dependencies.kt b/buildSrc/src/main/kotlin/Dependencies.kt
@@ -10,6 +10,7 @@ object Versions {
     const val CORE_KTX = "1.2.0"
     const val FRAGMENT_KTX = "1.2.4"
     const val ANDROID_MAVEN = "2.1"
+    const val DETEKT_RUNTIME = "1.8.0"
 
     const val COMPILE_SDK_VERSION = 28
     const val MIN_SDK_VERSION = 21