Merge pull request #13 from vinted/feature/error_when_PR_has_migratio…

…n_and_code Raise the level to error for PRs that contain migrations AND code
vinted · Jul 31, 2023 · 81ce43e · 81ce43e
2 parents 5c9daed + fec2def
commit 81ce43e
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 24 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    pronto-rails_migrations (0.14.1)
+    pronto-rails_migrations (0.14.2)
       faraday (~> 1.10.0)
       multipart-post (~> 2.1.1)
       pronto (>= 0.10.0)
@@ -10,9 +10,9 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.8.0)
-      public_suffix (>= 2.0.2, < 5.0)
-    faraday (1.10.0)
+    addressable (2.8.4)
+      public_suffix (>= 2.0.2, < 6.0)
+    faraday (1.10.3)
       faraday-em_http (~> 1.0)
       faraday-em_synchrony (~> 1.0)
       faraday-excon (~> 1.1)
@@ -35,41 +35,39 @@ GEM
     faraday-patron (1.0.0)
     faraday-rack (1.0.0)
     faraday-retry (1.0.3)
-    gitlab (4.18.0)
-      httparty (~> 0.18)
+    gitlab (4.19.0)
+      httparty (~> 0.20)
       terminal-table (>= 1.5.1)
-    httparty (0.20.0)
-      mime-types (~> 3.0)
+    httparty (0.21.0)
+      mini_mime (>= 1.0.0)
       multi_xml (>= 0.5.2)
-    mime-types (3.4.1)
-      mime-types-data (~> 3.2015)
-    mime-types-data (3.2022.0105)
+    mini_mime (1.1.2)
     multi_xml (0.6.0)
     multipart-post (2.1.1)
     octokit (4.22.0)
       faraday (>= 0.9)
       sawyer (~> 0.8.0, >= 0.5.3)
-    pronto (0.11.0)
-      gitlab (~> 4.4, >= 4.4.0)
-      httparty (>= 0.13.7)
-      octokit (~> 4.7, >= 4.7.0)
+    pronto (0.11.1)
+      gitlab (>= 4.4.0, < 5.0)
+      httparty (>= 0.13.7, < 1.0)
+      octokit (>= 4.7.0, < 7.0)
       rainbow (>= 2.2, < 4.0)
-      rexml (~> 3.2)
-      rugged (>= 0.23.0, < 1.1.0)
+      rexml (>= 3.2.5, < 4.0)
+      rugged (>= 0.23.0, < 2.0)
       thor (>= 0.20.3, < 2.0)
-    public_suffix (4.0.7)
+    public_suffix (5.0.3)
     rainbow (3.1.1)
     rake (12.3.3)
-    rexml (3.2.5)
+    rexml (3.2.6)
     ruby2_keywords (0.0.5)
-    rugged (1.0.1)
+    rugged (1.6.3)
     sawyer (0.8.2)
       addressable (>= 2.3.5)
       faraday (> 0.8, < 2.0)
     terminal-table (3.0.2)
       unicode-display_width (>= 1.1.1, < 3)
-    thor (1.2.1)
-    unicode-display_width (2.1.0)
+    thor (1.2.2)
+    unicode-display_width (2.4.2)
 
 PLATFORMS
   ruby

diff --git a/lib/pronto/rails_migrations.rb b/lib/pronto/rails_migrations.rb
@@ -10,7 +10,7 @@ def run
         messages << message(
           patch,
           'Run migrations in a separate PR from application code changes.',
-          level: :warning
+          level: :error
         )
       end
 

diff --git a/lib/pronto/rails_migrations/version.rb b/lib/pronto/rails_migrations/version.rb
@@ -1,3 +1,3 @@
 module Pronto
-  RAILS_MIGRATIONS_VERSION = '0.14.1'
+  RAILS_MIGRATIONS_VERSION = '0.14.2'
 end