Fix shutdown save peers utreexo #280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaoleal
reviewed
Nov 19, 2024
|
I have seen the errors on linting and build_docker. I am looking into it. |
|
I think the build docker error is unrelated, cc @Davidson-Souza |
|
To fix linting, do I need to use the nightly rust? |
|
Yes, you can run |
|
A doubt that I had when writting the code was if I needed to save every utreexo peers or just "good" peers. I opted for just the "good" ones. |
The idea is to save only the ones we are connected to, so they are by definition good |
|
Is there anything I should improve/modify before merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to save good utreexo peers to a anchors.json file