Remove an externally reachable unwrap #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davidson-Souza
force-pushed
the
remove-unwrap
branch
from
bbe1b2a
to
4690706
Compare
|
What a dangerous code 😆 LGTM 👍 |
If some peer sent us a block without proof to our `RunningNode` we would try to unwrap the `udata` and panic. This commit actually handles the case and remove the panic
Davidson-Souza
force-pushed
the
remove-unwrap
branch
from
4690706
to
08c0f40
Compare
|
Updated to ask for proofs in the re-request. Diff: - NodeRequest::GetBlock((vec![block.block.block_hash()], false)),
+ NodeRequest::GetBlock((vec![block.block.block_hash()], true)), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If some peer sent us a block without proof to our
RunningNodewe would try to unwrap theudataand panic. This commit actually handles the case and remove the panic