Generate runtime options file using Babel #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously runtime options were generated using manually created AST nodes and `astring` module. This was hindersome to maintain, so I decided to switch to using recast at first, but quickly found it doesn't support some of AST types that we need, so I've migrated to Babel modules instead, which provide all the nice APIs and generate more correct code than recast.
🦋 Changeset detectedLatest commit: 1583989 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for vintl-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously runtime options were generated using manually created AST
nodes and
astringmodule. This was hindersome to maintain, so Idecided to switch to using recast at first, but quickly found it doesn't
support some of AST types that we need, so I've migrated to Babel
modules instead, which provide all the nice APIs and generate more
correct code than recast.