Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: augment #app rather than nuxt/app #81

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

danielroe
Copy link
Contributor

We're seeing some cases where when users augment #app/nuxt rather than #app, they can lose type support once the (future default) typescript module resolution of 'bundler' is enabled.

While searching for repos using that, I also came across this usage (nuxt/app). While it should be fine, I thought it would still be worth raising this PR for you to consider, in case it might prevent issues in future.

related: nuxt/nuxt#24193

Copy link

changeset-bot bot commented Nov 22, 2023

⚠️ No Changeset found

Latest commit: 08cfceb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for vintl-nuxt canceled.

Name Link
🔨 Latest commit 08cfceb
🔍 Latest deploy log https://app.netlify.com/sites/vintl-nuxt/deploys/655e828e985d4200084536c2

@danielroe danielroe changed the title fix: augment #app rather than nuxt/app fix: augment #app rather than nuxt/app Nov 22, 2023
@brawaru brawaru merged commit 08cfceb into vintl-dev:main Nov 23, 2023
4 checks passed
@danielroe danielroe deleted the app-augmentation branch November 23, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants