Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

test: add azure test for os-replace #197

Merged
merged 2 commits into from
Mar 27, 2024
Merged

test: add azure test for os-replace #197

merged 2 commits into from
Mar 27, 2024

Conversation

shi2wei3
Copy link
Collaborator

fix #195

@shi2wei3 shi2wei3 marked this pull request as ready for review March 22, 2024 10:24
packages = [
{ name = "cloud-init" },
{ name = "WALinuxAgent" },
{ name = "podman" },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting...wait, why are we generating a custom azure image? The goal is to test installing via os-replace on the stock RHEL one, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. But there's no RHEL9 and CS9 image on Azure. We have to upload by our own and use it to boot first. Then run bootc install.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait...really? Wow, OK yep https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/9/html/deploying_rhel_9_on_microsoft_azure/index is quite clear.

Though...if this is the case, in the end I'm not actually sure that this is as important for us to test, because this use case from a customer PoV I think basically becomes using bootc-image-builder to upload the target container directly to Azure, right? Indirecting in this way would feel strange.

Not saying there's anything wrong with this test though! We might as well do it, so don't block merging. I actually love how it's combining things end to end (nice work!).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's not free, and needs rhc subscription.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cgwalters

  • You are right, there is RHEL golden image on Azure, but our test might rely on the latest eng RHEL composes especially the podman package, and we don't have a easy way to access internal network to fetch those packages, so we plan to built it by ourselves.
  • For CentOS stream, there is no CentOS images being built by Red Hat or Microsoft on Azure, so do you think we still need to cover CentOS?

shi2wei3 and others added 2 commits March 27, 2024 23:26
Signed-off-by: Wei Shi <[email protected]>

test: add azure test for os-replace

Signed-off-by: Wei Shi <[email protected]>
Signed-off-by: Xiaofeng Wang <[email protected]>
@henrywang henrywang merged commit a598883 into virt-s1:main Mar 27, 2024
4 checks passed
@shi2wei3 shi2wei3 deleted the azure branch March 29, 2024 02:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider adding azure tests
3 participants