Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communities] Refactor pallet structure #312

Merged

Conversation

pandres95
Copy link
Member

This PR addresses some improvements over the pallet structure:

  • Resolve an ambiguity between pallet:CommunityMetadata and types::CommunityMetadata.
  • Split logical modules within the pallet
  • Split tests into files for easier handling
  • Apply weight option into #[pallet::call(weight)]
  • Remove excessive verbosity and unified certain naming conventions:
    • CommunityMembersMembers
    • CommunityMembersCountMembersCount
    • CommunityInfoInfo
    • types::Communitytypes::CommunityInfo
  • Update documentation to reflect the current status regarding community tokens

@pandres95 pandres95 self-assigned this Oct 5, 2023
@pandres95 pandres95 added the refactor Refactor of existing code. label Oct 5, 2023
@pandres95 pandres95 changed the title Refactor: Organise pallet [Communities] Refactor pallet structure Oct 5, 2023
@pandres95 pandres95 force-pushed the pandres95-communities-refactor branch from 38aa884 to e87b595 Compare October 5, 2023 15:35
@pandres95 pandres95 merged commit 3cacc62 into feature/pandres95-communities-pallet Oct 6, 2023
4 checks passed
@pandres95 pandres95 deleted the pandres95-communities-refactor branch October 6, 2023 17:23
@pandres95 pandres95 added the hacktoberfest-accepted This PR participates on Hacktobefest label Oct 19, 2023
olanod pushed a commit that referenced this pull request Oct 30, 2023
* refactor(pallets/communities): resolve ambiguity between CommunityMetadata storage type and struct

* refactor(pallets/communities): split logical modules within pallet

* refactor(communities:pallet): use pallet::call(weight) option

* refactor(pallet/communities): remove excessive verbosity

* change(pallet/communities): update documentation regarding tokens

* refactor(pallets/communities): split types into multiple files
olanod pushed a commit that referenced this pull request Nov 21, 2023
* refactor(pallets/communities): resolve ambiguity between CommunityMetadata storage type and struct

* refactor(pallets/communities): split logical modules within pallet

* refactor(communities:pallet): use pallet::call(weight) option

* refactor(pallet/communities): remove excessive verbosity

* change(pallet/communities): update documentation regarding tokens

* refactor(pallets/communities): split types into multiple files
olanod pushed a commit that referenced this pull request Dec 4, 2023
* refactor(pallets/communities): resolve ambiguity between CommunityMetadata storage type and struct

* refactor(pallets/communities): split logical modules within pallet

* refactor(communities:pallet): use pallet::call(weight) option

* refactor(pallet/communities): remove excessive verbosity

* change(pallet/communities): update documentation regarding tokens

* refactor(pallets/communities): split types into multiple files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted This PR participates on Hacktobefest refactor Refactor of existing code.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant