-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Communities] Refactor pallet structure #312
Merged
pandres95
merged 6 commits into
feature/pandres95-communities-pallet
from
pandres95-communities-refactor
Oct 6, 2023
Merged
[Communities] Refactor pallet structure #312
pandres95
merged 6 commits into
feature/pandres95-communities-pallet
from
pandres95-communities-refactor
Oct 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adata storage type and struct
pandres95
changed the title
Refactor: Organise pallet
[Communities] Refactor pallet structure
Oct 5, 2023
pandres95
force-pushed
the
pandres95-communities-refactor
branch
from
October 5, 2023 15:35
38aa884
to
e87b595
Compare
pandres95
merged commit Oct 6, 2023
3cacc62
into
feature/pandres95-communities-pallet
4 checks passed
olanod
pushed a commit
that referenced
this pull request
Oct 30, 2023
* refactor(pallets/communities): resolve ambiguity between CommunityMetadata storage type and struct * refactor(pallets/communities): split logical modules within pallet * refactor(communities:pallet): use pallet::call(weight) option * refactor(pallet/communities): remove excessive verbosity * change(pallet/communities): update documentation regarding tokens * refactor(pallets/communities): split types into multiple files
olanod
pushed a commit
that referenced
this pull request
Nov 21, 2023
* refactor(pallets/communities): resolve ambiguity between CommunityMetadata storage type and struct * refactor(pallets/communities): split logical modules within pallet * refactor(communities:pallet): use pallet::call(weight) option * refactor(pallet/communities): remove excessive verbosity * change(pallet/communities): update documentation regarding tokens * refactor(pallets/communities): split types into multiple files
olanod
pushed a commit
that referenced
this pull request
Dec 4, 2023
* refactor(pallets/communities): resolve ambiguity between CommunityMetadata storage type and struct * refactor(pallets/communities): split logical modules within pallet * refactor(communities:pallet): use pallet::call(weight) option * refactor(pallet/communities): remove excessive verbosity * change(pallet/communities): update documentation regarding tokens * refactor(pallets/communities): split types into multiple files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some improvements over the pallet structure:
pallet:CommunityMetadata
andtypes::CommunityMetadata
.weight
option into#[pallet::call(weight)]
CommunityMembers
→Members
CommunityMembersCount
→MembersCount
CommunityInfo
→Info
types::Community
→types::CommunityInfo