Feat configuring payments pallet kreivo #328
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is configuring the Payments pallet into the Kreivo runtime and also it generates the weights for each extrinsic.
Something interesting is that a test
weights()
was added where we can have how much each extrinsic occupies in the block and some interesting statistics like how many max tx we could have in a block.Below the tests results:
The command line used to generate the weights is the following:
Important: It worths considering that these benchmarks were calculated using a Macbook M1 Pro with 32GB of ram. Depending on the hardware used to run the collators all the numbers and statistics might change. This should be properly done in #179
Closes #327 #309