feat: Configure Gas Tank for Memberships #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…config` for memberships being created
…` / Add `MakeTank` to `pallet_communities_manager`
…s for blocks up to `P` back in the past.
pandres95
force-pushed
the
feat/configure-gas-tanks-on-memberships
branch
from
55f8c30 to
00a0ba0
Compare
…et_communities_manager`
…utes from items in `MembershipsManagementCollection` to items in communities' collections.
pandres95
force-pushed
the
feat/configure-gas-tanks-on-memberships
branch
from
dee90d5 to
ebd262e
Compare
… that are not expired
pandres95
force-pushed
the
feat/configure-gas-tanks-on-memberships
branch
from
ebd262e to
0cdbe14
Compare
olanod
requested changes
Dec 19, 2024
There was a problem hiding this comment.
I'd suggest moving the KreivoMemberships in a more generic form to frame contrib where the non fungibles implementation is applied to a struct (instead of T), that accepts a configurable list of system attributes that should be copied from the manager collection to the new collection.
…ps manager pallet reference with `NonFungiblesMemberships` support structure.
…copy certain fields (such as gas and expirations) when a membership is assigned.
pandres95
force-pushed
the
feat/configure-gas-tanks-on-memberships
branch
3 times, most recently
from
7535c70 to
e3b1600
Compare
pandres95
force-pushed
the
feat/configure-gas-tanks-on-memberships
branch
from
e3b1600 to
9d1ee48
Compare
olanod
requested changes
Jan 7, 2025
olanod
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request configures
pallet-communities-managerto set gas tanks on new and existing memberships.