Skip to content

Commit

Permalink
buyerid not spec
Browse files Browse the repository at this point in the history
  • Loading branch information
visavi committed Oct 22, 2019
1 parent bf12b81 commit d1656a2
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ $device->setUa('Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:69.0) Gecko/20100101

$user = new User();
$user->setId('test1')
->setBuyerid('xxxxxxxxx');
->setBuyeruid('xxxxxxxxx');

$bidRequest = new BidRequest();
$bidRequest
Expand Down
18 changes: 9 additions & 9 deletions src/BidRequest/User.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,20 @@ class User implements Arrayable
use ToArray;

/**
* Exchange-specific ID for the user. At least one of id or buyerid is recommended
* Exchange-specific ID for the user. At least one of id or buyeruid is recommended
*
* @recommended
* @var string
*/
protected $id;

/**
* Buyer-specific ID for the user as mapped by the exchange for the buyer. At least one of buyerid or id is recommended.
* Buyer-specific ID for the user as mapped by the exchange for the buyer. At least one of buyeruid or id is recommended.
*
* @recommended
* @var string
*/
protected $buyerid;
protected $buyeruid;

/**
* Gender as "M" male, "F" female, "O" Other. (Null indicates unknown)
Expand Down Expand Up @@ -107,20 +107,20 @@ public function setId($id)
/**
* @return string
*/
public function getBuyerid()
public function getBuyeruid()
{
return $this->buyerid;
return $this->buyeruid;
}

/**
* @param string $buyerid
* @param string $buyeruid
* @return $this
* @throws \OpenRtb\Tools\Exceptions\ExceptionInvalidValue
*/
public function setBuyerid($buyerid)
public function setBuyeruid($buyeruid)
{
$this->validateString($buyerid);
$this->buyerid = $buyerid;
$this->validateString($buyeruid);
$this->buyeruid = $buyeruid;
return $this;
}

Expand Down
2 changes: 1 addition & 1 deletion tests/HydratorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public function testHydrate()
$this->assertInstanceOf('OpenRtb\Tools\Classes\ArrayCollection', $object->getImp());
$this->assertInstanceOf('OpenRtb\BidRequest\Imp', $object->getImp()->current());
$this->assertEquals('1', $object->getImp()->current()->getId());
// $this->assertEquals('y4O57Y16t5p449R94e7VQKs35fg7T87F', $object->getUser()->getBuyerid());
// $this->assertEquals('y4O57Y16t5p449R94e7VQKs35fg7T87F', $object->getUser()->getBuyeruid());
}

public function testHydrateBidRequest()
Expand Down

0 comments on commit d1656a2

Please sign in to comment.