Merge pull request #26 from vishaltanwar96/feature/start-indexing-red…

…eem-code-in-a-gc create unique index for redeem code as it should be unique
vishaltanwar96 · Nov 4, 2022 · cd086d6 · cd086d6
2 parents d78bfef + f03f532
commit cd086d6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/gcmanager/dependencies.py b/gcmanager/dependencies.py
@@ -2,6 +2,7 @@
 from urllib.parse import quote
 
 from kink import Container
+from pymongo import ASCENDING
 from pymongo import MongoClient
 from pymongo.collection import Collection
 from pymongo.database import Database
@@ -61,7 +62,9 @@ def _build_mongodb_database(container: Container) -> None:
 def _build_mongodb_collection(container: Container) -> None:
     database = container[Database]
     settings = container[Settings]
-    container[Collection] = lambda c: database[settings["MONGODB_GC_COLLECTION_NAME"]]
+    collection = database[settings["MONGODB_GC_COLLECTION_NAME"]]
+    collection.create_index([("redeem_code", ASCENDING)], unique=True)
+    container[Collection] = lambda c: collection
 
 
 def _build_mongodb_repository(container: Container) -> None:

diff --git a/tests/unit/test_container.py b/tests/unit/test_container.py
@@ -24,12 +24,12 @@ def test_raises_exception_when_required_env_variables_absent(self) -> None:
 
     def test_returns_container_when_required_env_variables_present(self) -> None:
         when(os.environ).get("APP_ENV").thenReturn("PROD")
-        when(os.environ).get("MONGODB_USERNAME").thenReturn("someuser")
-        when(os.environ).get("MONGODB_PASSWORD").thenReturn("somepassword")
-        when(os.environ).get("MONGODB_HOST").thenReturn("somehost")
-        when(os.environ).get("MONGODB_PORT", "27017").thenReturn("27017")
-        when(os.environ).get("MONGODB_DBNAME", "gcmanager").thenReturn("somedb")
+        when(os.environ).get("MONGODB_USERNAME").thenReturn("testing_user")
+        when(os.environ).get("MONGODB_PASSWORD").thenReturn("testing")
+        when(os.environ).get("MONGODB_HOST").thenReturn("localhost")
+        when(os.environ).get("MONGODB_PORT", "27017").thenReturn("27020")
+        when(os.environ).get("MONGODB_DBNAME", "gcmanager").thenReturn("testdb")
         when(os.environ).get("MONGODB_GC_COLLECTION_NAME", "giftcards").thenReturn(
-            "somecollection",
+            "testcollection",
         )
         self.assertIsInstance(build_dependency_container(), Container)