Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MIT license text and update package.json #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add MIT license text and update package.json #16

wants to merge 2 commits into from

Conversation

pnemade
Copy link

@pnemade pnemade commented Dec 12, 2014

Hi,
I am packaging this in Fedora Linux and we have packaging policy to include license text also. Can you please commit this pull request and release new tarball in npm.

@notslang
Copy link

👍, Though we should probably remove it from the readme now that it's mentioned in the package.json and in a file... seems redundant.

@pnemade
Copy link
Author

pnemade commented Dec 12, 2014

Its always good to add license tag in package.json and its full license text in a separate file. We have a packaging review check which says "If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. "

Also, many other nodejs module owners on github has accepted such pull requests.

@notslang
Copy link

Yeah, I'm saying the "License" section of ./Readme.md is now redundant and should be removed... putting it into the package.json & separate file is a great idea.

@pnemade
Copy link
Author

pnemade commented Dec 12, 2014

Oh Sorry I misunderstood your last comment. I have rebased pull request to remove license information from Readme.md also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants